[llvm] r290024 - [Hexagon] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Krzysztof Parzyszek via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 19 05:06:16 PST 2016


On 12/19/2016 7:04 AM, Malcolm Parsons via llvm-commits wrote:
> On 18 December 2016 at 15:56, Eugene Zelenko <eugene.zelenko at gmail.com> wrote:
>> On Sun, Dec 18, 2016 at 7:47 AM, Malcolm Parsons
>> <malcolm.parsons at gmail.com> wrote:
>>> On 17 December 2016 at 01:09, Eugene Zelenko via llvm-commits
>>> <llvm-commits at lists.llvm.org> wrote:
>>>> -    if (P == INT_MIN)
>>>> +    if (P == std::numeric_limits<int>::max())
>>>
>>> MIN -> max?
>>
>> I'm very sorry to introduce problem. And thank you for spotting it!
>>
>> But could not fix it until next year. Could you please commit this change?
>
> r290100
>

Thanks Malcolm.

How was this problem introduced?  Was this a manual change, or is it a 
problem with some tool?

-Krzysztof

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
hosted by The Linux Foundation


More information about the llvm-commits mailing list