[PATCH] D27706: [ARM] GlobalISel: Support i1 add and ABI extensions

Diana Picus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 19 03:48:49 PST 2016


rovka added inline comments.


================
Comment at: lib/Target/ARM/ARMInstructionSelector.cpp:108
+    isSExt = true;
+  // Fallthrough!
   case G_ZEXT: {
----------------
t.p.northover wrote:
> We've got an `LLVM_FALLTHROUGH` for this so that the actual attribute is used when available.
Ok, will fix before committing. Anything else?


https://reviews.llvm.org/D27706





More information about the llvm-commits mailing list