[PATCH] D25360: [XRay] [NFC] [compiler-rt] Move machine-dependent code into machine-dependent files.

[Dean Michael Berris via Phabricator via llvm-commits]

dberris requested changes to this revision.
dberris added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/xray/xray_inmemory_log.cc:108
 
+static int __xray_OpenLogFile() {
+  // FIXME: Figure out how to make this less stderr-dependent.
----------------
Probably want to add `XRAY_NEVER_INSTRUMENT` as an attribute, because of weird recursion problems.


================
Comment at: lib/xray/xray_x86_64.cc:66
+  } else {
+    Report("Unable to determine CPU frequency for TSC accounting.");
+  }
----------------
Did you miss an `\n` in the string?


https://reviews.llvm.org/D25360