[PATCH] D27642: DebugInfo: Added support for Checksum debug info feature (LLVM IR part)

David Majnemer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 18 12:44:40 PST 2016


majnemer added inline comments.


================
Comment at: include/llvm/IR/DebugInfoMetadata.h:478
+    CSK_SHA1,
+    CSK_Num // Should be last enumeration.
+  };
----------------
I think it'd be nicer to instead do `CSK_Last = CSK_SHA1` and use `CSK_Last + 1` instead of `CSK_Num`. It makes it nicer to switch over the `ChecksumKind` type.


https://reviews.llvm.org/D27642





More information about the llvm-commits mailing list