[PATCH] D27676: [ELF] - Use full object name if source file name exist when reporting errors.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 18 06:16:23 PST 2016

grimar added a comment.

In https://reviews.llvm.org/D27676#622869, @silvas wrote:

> In https://reviews.llvm.org/D27676#622851, @ruiu wrote:
> > I thought about this for a while. I'd say that having `foo.a(foo.o)(foo.c)` and `foo.o(foo.c)` are not correct because they are inconsistent. If the former were `foo.a(foo.o(foo.c))`, the two are at least consistent, but I guess that's hard to read.
> >
> > We have a lot of combinations here.
> >
> > - Is an object file in an archive file? Yes or no
> > - Do we know source filename? Yes or not
> > - What do we know about the error location inside of the object file: Line number in the original source code, section name in an object file, or nothing
> I think we can keep the source file / line location information completely separate from the object file location information.

I tried to implement that idea in https://reviews.llvm.org/D27900.


More information about the llvm-commits mailing list