[PATCH] D27392: Vectorcall Calling Convention - Adding CodeGen Complete Support

Oren Ben Simhon via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 18 00:38:50 PST 2016

oren_ben_simhon marked 8 inline comments as done.
oren_ben_simhon added inline comments.

Comment at: include/llvm/CodeGen/CallingConvLower.h:542-543
+  /// After running, it will sort the locs list.
+  template<class T>
+  void AnalyzeArgumentsSecondPass(const SmallVectorImpl<T>& Args, CCAssignFn Fn) {
+    unsigned NumFirstPassLocs = Locs.size();
majnemer wrote:
> Please clang-format this.
> Also, I think `Args` should be an `ArrayRef<T>`.
Thank you Reid and David.
I reran clang format on the latest patch.

Other functions that receive Args (Like, AnalyzeCallOperands, CheckReturn, etc.) use the SmallVector representation of the data.
So, I prefer to be consistent with them and leave it as SmallVectorImpl.



More information about the llvm-commits mailing list