[PATCH] D27819: Remove lld/Support/Memory.h.

Sean Silva via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 18 00:12:43 PST 2016


silvas accepted this revision.
silvas added a comment.
This revision is now accepted and ready to land.

Thanks for doing this, LGTM with a nit. Overall, it seems that keeping two copies for now is fine, since it is such a small amount of code.

Sorry about pushing so strongly about this, but there is already enough confusion/friction about the "library" vs "program" approach in LLD and I feel strongly that having this in an LLVM-style {include,lib} arrangement was just a little too much.



================
Comment at: ELF/Memory.h:19
 // Most objects are allocated using the arena allocators defined by this file.
 //
 //===----------------------------------------------------------------------===//
----------------
Consider adding a mention of the duplication with COFF here.


https://reviews.llvm.org/D27819





More information about the llvm-commits mailing list