[PATCH] D27893: [lit] Fix shtest-format test on Windows

Brian Gesiak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 17 20:41:19 PST 2016

modocache created this revision.
modocache added reviewers: ddunbar, echristo, beanz, delcypher.
modocache added a subscriber: llvm-commits.
Herald added a subscriber: mehdi_amini.

I'm not sure why, but when external_shell tests run 'cat' on a
non-existent file on my Windows environment, it *passes*. That
causes the shtest-format test to fail.

Running 'tail' on a non-existent file falis on Windows as it should, so
use that instead.



Index: utils/lit/tests/shtest-format.py
--- utils/lit/tests/shtest-format.py
+++ utils/lit/tests/shtest-format.py
@@ -16,7 +16,7 @@
 # CHECK-NEXT: line 2: failed test output on stdout
 # CHECK: Command Output (stderr):
-# CHECK-NEXT: cat: does-not-exist: No such file or directory
+# CHECK-NEXT: tail: cannot open 'does-not-exist' for reading: No such file or directory
 # CHECK: --
 # CHECK: FAIL: shtest-format :: external_shell/fail_with_bad_encoding.txt
Index: utils/lit/tests/Inputs/shtest-format/external_shell/fail.txt
--- utils/lit/tests/Inputs/shtest-format/external_shell/fail.txt
+++ utils/lit/tests/Inputs/shtest-format/external_shell/fail.txt
@@ -2,4 +2,4 @@
 # RUN: echo "line 1: failed test output on stdout"
 # RUN: echo "line 2: failed test output on stdout"
-# RUN: cat "does-not-exist"
+# RUN: tail "does-not-exist"

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27893.81869.patch
Type: text/x-patch
Size: 994 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161218/aa4b6c24/attachment.bin>

More information about the llvm-commits mailing list