[PATCH] D27834: AMDGPU/SI: Add a MachineMemOperand when lowering llvm.amdgcn.buffer.load.*

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM except for minor fixes



================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:2720
+      Op.getOperand(5), // glc
+      Op.getOperand(6), // slc
+    };
----------------
Trailing comma


================
Comment at: lib/Target/AMDGPU/SIMachineFunctionInfo.h:489
 
+  AMDGPUBufferPseudoSourceValue *getBufferPSV() {
+    return BufferPSV.get();
----------------
const ,const. You can probably return const &


================
Comment at: lib/Target/AMDGPU/SIMachineFunctionInfo.h:493-495
   AMDGPUImagePseudoSourceValue *getImagePSV() {
     return ImagePSV.get();
   }
----------------
ditto


================
Comment at: test/CodeGen/AMDGPU/llvm.amdgcn.buffer.load.ll:117
+; we only have check lines for VI.
+; VI-LABEL: buffer_load_mmo
+; VI: v_mov_b32_e32 [[ZERO:v[0-9]+]], 0
----------------
CHECK-LABEL, should also end with :


https://reviews.llvm.org/D27834