[PATCH] D25318: [DAG] Don't increase SDNodeOrder for dbg.value/declare.
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Dec 17 14:58:24 PST 2016
fhahn added a comment.
Ping. Do you think the updated test cases are sufficient or would it help to provide a C example? I have one lying around somewhere, but the test case is quite ugly.
The patch only changes the `Order` value for debug intrinsics, so that the `Order` of debug intrinsics is equal to the previous non-debug instruction. The order of non-debug instructions is not affected by the change (as far as I can tell), because all non-debug instruction still have distinct `Order` values.
The order of debug instructions between two non-debug instructions could change though, because their order now relies on the order returned by DAG->GetDbgValues(N), but this shouldn't be a problem, right?
More information about the llvm-commits