[PATCH] D27868: [libFuzzer] Diff 23 - Properly use compiler options supported on Windows.

[Kostya Serebryany via Phabricator via llvm-commits]

kcc added inline comments.


================
Comment at: lib/Fuzzer/test/CMakeLists.txt:30
+  # Only include coverage options supported for Windows.
+  set(CMAKE_CXX_FLAGS "${LIBFUZZER_FLAGS_BASE} -fsanitize-coverage=edge")
+else()
----------------
mpividori wrote:
> kcc wrote:
> > mpividori wrote:
> > > kcc wrote:
> > > > Nope. =edge should not be used any more with libFuzzer. 
> > > > I am going to delete the libFuzzer code that supports it pretty soon. 
> > > > 
> > > > What's wrong with trace-pc-guard,trace-cmp on windows? 
> > > @kcc Ok. I couldn't get that information from the documentation. 
> > > Trace-* options doesn't work on windows. I can try to fix them, I would need some time.
> > >> Ok. I couldn't get that information from the documentation. 
> > Which documentation?
> > http://llvm.org/docs/LibFuzzer.html mentions only trace-pc-guard and trace-pc
> > 
> > >> Trace-* options doesn't work on windows. I can try to fix them, I would need some time.
> > What exactly is not working? (probably let's take it into another thread) 
> > 
> @kcc I refer to the Sanitizer Coverage documentation: http://clang.llvm.org/docs/SanitizerCoverage.html
> It doesn't mention which options are supported on Windows.
Yep, because non of it is supported on windows (in terms of 'my team supporting them n windows').
But the trace- options don't have sanitizer-run-time portion when used with libFuzzer, so it's a pure compiler feature, nothing (??) OS-specific.
Except maybe the way how weak functions work... Hmmm. You will need to check this. 

Anyway, libFuzzer will soon stop supporting anything but the options being used currently. 


Repository:
  rL LLVM

https://reviews.llvm.org/D27868