[PATCH] D27868: [libFuzzer] Diff 23 - Properly use compiler options supported on Windows.

[Kostya Serebryany via Phabricator via llvm-commits]

kcc added inline comments.


================
Comment at: lib/Fuzzer/test/CMakeLists.txt:30
+  # Only include coverage options supported for Windows.
+  set(CMAKE_CXX_FLAGS "${LIBFUZZER_FLAGS_BASE} -fsanitize-coverage=edge")
+else()
----------------
mpividori wrote:
> kcc wrote:
> > Nope. =edge should not be used any more with libFuzzer. 
> > I am going to delete the libFuzzer code that supports it pretty soon. 
> > 
> > What's wrong with trace-pc-guard,trace-cmp on windows? 
> @kcc Ok. I couldn't get that information from the documentation. 
> Trace-* options doesn't work on windows. I can try to fix them, I would need some time.
>> Ok. I couldn't get that information from the documentation. 
Which documentation?
http://llvm.org/docs/LibFuzzer.html mentions only trace-pc-guard and trace-pc

>> Trace-* options doesn't work on windows. I can try to fix them, I would need some time.
What exactly is not working? (probably let's take it into another thread) 



================
Comment at: lib/Fuzzer/test/CMakeLists.txt:37
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g")
+else()
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /Zi")
----------------
mpividori wrote:
> kcc wrote:
> > zturner wrote:
> > > kcc wrote:
> > > > hmmm. What is the 'else' compiler? 
> > > clang-cl I imagine, but /Z7 is more correct than /Zi.  To make the else clear, you could say `elseif(CLANG_CL)`
> > Does clang-cl not support -g? 
> Yes, clang-cl doesn't support `-g`.
Sad, but ok. 


Repository:
  rL LLVM

https://reviews.llvm.org/D27868