[PATCH] D27775: [ThinLTO] Import composite types as declarations

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 16 13:30:27 PST 2016

tejohnson added inline comments.

Comment at: lib/Bitcode/Reader/MetadataLoader.cpp:733
+      // by the importing module, in which case the existing definition is
+      // used.
+      if (IsImporting && !ImportFullTypeDefinitions &&
mehdi_amini wrote:
> Can you avoid calling all the getMD and so above in the case you're nullifying them?
> As I'm working on lazy-loading, this would still trigger the load from bitcode and create the MD into memory even if you don't attach them in the MD graph.
Good idea, done.


More information about the llvm-commits mailing list