[PATCH] D26769: [IR] Remove the DIExpression field from DIGlobalVariable.

Adrian Prantl via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 16 11:53:22 PST 2016


On Dec 16, 2016, at 11:39 AM, Adrian Prantl via llvm-commits <llvm-commits at lists.llvm.org> wrote:

Author: adrian
Date: Fri Dec 16 13:39:01 2016
New Revision: 289982

URL: http://llvm.org/viewvc/llvm-project?rev=289982&view=rev
Revert "[IR] Remove the DIExpression field from DIGlobalVariable."

This reverts commit 289920 (again).
I forgot to implement a Bitcode upgrade for the case where a DIGlobalVariable
has not DIExpression. Unfortunately it is not possible to safely upgrade
these variables without adding a flag to the bitcode record indicating which
version they are.

My plan of record is to roll the planned follow-up patch that adds a
unit: field to DIGlobalVariable into this patch before recomitting.
This way we only need one Bitcode upgrade for both changes (with a
version flag in the bitcode record to safely distinguish the record

Sorry for the churn!

More information about the llvm-commits mailing list