[PATCH] D27704: [ARM] GlobalISel: Allow i16 and i8 adds

Tim Northover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 16 11:26:02 PST 2016

t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.

This one also looks like 2 patches really (select more COPY cases, support more args), though again both pretty sensible.

Comment at: lib/Target/ARM/ARMCallLowering.cpp:36
   EVT VT = TLI.getValueType(DL, T);
-  return VT.isSimple() && VT.isInteger() &&
-         VT.getSimpleVT().getSizeInBits() == 32;
+  if (!VT.isSimple() || !VT.isInteger())
+    return false;
Checking against vectors is probably good here, since you're changing it anyway. Somewhat surprisingly `isInteger` returns true for them.


More information about the llvm-commits mailing list