[PATCH] D27521: AArch64 Cortex-A57 FDIV/FSQRT scheduling fix (W-unit)

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

Can you run any benchmark and share relative numbers? Despite the fact that the change is obvious, you may uncover pre-existing bugs in the compiler that need addressing before we can change this. The LLVM test-suite, SPEC, EEMBC, anything would help to have an idea.

cheers,
--renato



================
Comment at: test/CodeGen/AArch64/arm64-misched-A57-div-fix.ll:5
+;
+; RUN: llc < %s -mtriple=arm64-linux-gnu -mcpu=cortex-a57 -enable-misched -verify-misched -debug-only=misched -o - 2>&1 > /dev/null | not grep A57UnitX
+
----------------
rovka wrote:
> Tests shouldn't rely on grep, please use FileCheck instead.
> http://llvm.org/docs/TestingGuide.html#writing-new-regression-tests
It should also check for the unit you want to appear, not just the one you don't. :)


https://reviews.llvm.org/D27521