[PATCH] D26989: Use continuous boosting factor for complete unroll.

Dehao Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 16 08:30:30 PST 2016

danielcdh added a comment.

Thanks for the review!

Chandler, could you help take a look at this patch too?


Comment at: test/Transforms/LoopUnroll/full-unroll-heuristics-dce.ll:1
-; RUN: opt < %s -S -loop-unroll -unroll-max-iteration-count-to-analyze=100 -unroll-dynamic-cost-savings-discount=1000 -unroll-threshold=10 -unroll-percent-dynamic-cost-saved-threshold=60 | FileCheck %s
+; RUN: opt < %s -S -loop-unroll -unroll-max-iteration-count-to-analyze=100 -unroll-threshold=12 -unroll-max-percent-threshold-boost=400 | FileCheck %s
 target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
mzolotukhin wrote:
> Minor: if possible, please don't change `-unroll-threshold=12`. We're replacing `-dynamic-cost-savings-discount` and `-unroll-percent-dynamic-cost-saved-threshold`, so the changes should touch only them.
Because we are now using linear equation to compute boosting factor, it is not enough to boost 10 to the required threshold. That's the original reason I used non-linear equation.


More information about the llvm-commits mailing list