[PATCH] D24226: [PM] Provide an initial, minimal port of the inliner to the new pass manager.
Sanjoy Das via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 16 07:51:57 PST 2016
sanjoy added a comment.
Comment at: lib/Transforms/IPO/Inliner.cpp:808
+ // also need to use an updatable pointer for the SCC as a consequence.
+ SmallVector<LazyCallGraph::Node *, 16> Nodes;
+ for (auto &N : InitialC)
> sanjoy wrote:
> > Why not `SmallVector<LazyCallGraph::Node *, 16> Nodes(InitialC.begin(), InitialC.end());`?
> Because it doesn't compile -- we need pointers not references.
> Eventially with a range constructor and an adaptor this will work, but today the current code seemed like the least typing. =[
Ah, okay; I missed the `&`.
More information about the llvm-commits