[PATCH] D27829: Add ARM support to update_llc_test_checks.py

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 16 02:46:54 PST 2016


RKSimon added inline comments.


================
Comment at: test/CodeGen/ARM/vzip.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
 ; RUN: llc -mtriple=arm-eabi -mattr=+neon %s -o - | FileCheck %s
----------------
chandlerc wrote:
> efriedma wrote:
> > chandlerc wrote:
> > > Is it worth commenting? We haven't in x86 land... For example, they are structured so that it is OK if some contributors just directly edit the test cases for expedience and we can re-synchronize with script output when useful.
> > The comment is autogenerated by update_llc_test_checks.py.  I don't see any reason to remove it in this context.
> Shows what I know. =] Carry on!
The autogenerated comments were added to the script (funnily enough by one of the ARM guys) to help developers who didn't know about update_llc_test_checks.py and got a little 'alarmed' about the size of some of the codegen.


Repository:
  rL LLVM

https://reviews.llvm.org/D27829





More information about the llvm-commits mailing list