[PATCH] D27838: Extract a TBAAVerifier out of the verifier (NFC)
Sanjoy Das via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 15 20:28:17 PST 2016
sanjoy added a comment.
lgtm but with one nit inline
Comment at: llvm/lib/IR/Verifier.cpp:4472
+ if (Diagnostic) \
I assume you'll add a `this->HasFailed = true` type thing here later?
Also, I'd mildly prefer using `this->Diagnostic` instead of `Diagnostic`, since this is in a macro.
Actually, why is this a macro at all? Can't it be a normal templated function just like `VerifierSupport::CheckFailed`?
More information about the llvm-commits