[PATCH] D27790: Pass sample pgo flags to thinlto.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 15 16:29:28 PST 2016

mehdi_amini added inline comments.

Comment at: lib/LTO/LTO.cpp:135
+    if (FileOrErr)
+      Hasher.update(FileOrErr.get()->getBuffer());
+  }
tejohnson wrote:
> Will this be expensive, for large apps with large profiles? Since this is the same for each backend, can we compute once and pass down?
If we go this route (and we should), then I rather do it as a separate patch and do as I suggested originally when the config was added there: have a `hash` method on the config itself where we would hash early the whole config part and do it once early.


More information about the llvm-commits mailing list