[compiler-rt] r289789 - [XRay][compiler-rt][NFC] Deduplicate code in x86-64 trampolines.

[Dean Michael Berris via llvm-commits]

Whoops -- I'll revert (if it hasn't been reverted yet).

On Fri, Dec 16, 2016 at 4:53 AM Ismail Donmez <ismail at i10z.com> wrote:

> Hi,
>
> On Thu, Dec 15, 2016 at 10:04 AM, Dean Michael Berris via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > Author: dberris
> > Date: Thu Dec 15 03:04:05 2016
> > New Revision: 289789
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=289789&view=rev
> > Log:
> > [XRay][compiler-rt][NFC] Deduplicate code in x86-64 trampolines.
> >
> > Summary:
> > The layout of all registers saved on stack shouldn't deviate and will be
> reused in future trampolines as well.
> >
> > While there, fix whitespace and clarify comments.
> >
> > Author: mpel
> >
> > Reviewers: dberris
> >
> > Subscribers: llvm-commits
> >
> > Differential Revision: https://reviews.llvm.org/D27799
> >
> > Modified:
> >     compiler-rt/trunk/lib/xray/xray_trampoline_x86_64.S
>
> This doesn't compile on Linux x86-64 (using the integrated assembler):
>
> [ 1311s]
> /home/abuild/rpmbuild/BUILD/llvm/projects/compiler-rt/lib/xray/xray_trampoline_x86_64.S:33:7:
> error: unexpected token in '.endm' directive
> [ 1311s] .endm SAVE_REGISTERS
> [ 1311s]       ^
> [ 1311s]
> /home/abuild/rpmbuild/BUILD/llvm/projects/compiler-rt/lib/xray/xray_trampoline_x86_64.S:52:7:
> error: unexpected token in '.endm' directive
> [ 1311s] .endm RESTORE_REGISTERS
> [ 1311s]       ^
> [ 1311s]
> /home/abuild/rpmbuild/BUILD/llvm/projects/compiler-rt/lib/xray/xray_trampoline_x86_64.S:64:2:
> error: invalid instruction mnemonic 'save_registers'
> [ 1311s]  SAVE_REGISTERS
> [ 1311s]  ^~~~~~~~~~~~~~
> [ 1311s]
> /home/abuild/rpmbuild/BUILD/llvm/projects/compiler-rt/lib/xray/xray_trampoline_x86_64.S:77:2:
> error: invalid instruction mnemonic 'restore_registers'
> [ 1311s]  RESTORE_REGISTERS
> [ 1311s]  ^~~~~~~~~~~~~~~~~
> [ 1311s]
> /home/abuild/rpmbuild/BUILD/llvm/projects/compiler-rt/lib/xray/xray_trampoline_x86_64.S:131:2:
> error: invalid instruction mnemonic 'save_registers'
> [ 1311s]  SAVE_REGISTERS
> [ 1311s]  ^~~~~~~~~~~~~~
> [ 1311s]
> /home/abuild/rpmbuild/BUILD/llvm/projects/compiler-rt/lib/xray/xray_trampoline_x86_64.S:142:2:
> error: invalid instruction mnemonic 'restore_registers'
> [ 1311s]  RESTORE_REGISTERS
> [ 1311s]  ^~~~~~~~~~~~~~~~~
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161215/8e39b984/attachment-0001.html>