[PATCH] D27762: Debug Info: Modified DIBuilder::createCompileUnit() to take DIFile instead of FileName and Directory. (LLVM part)

Amjad Aboud via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 15 14:01:57 PST 2016

aaboud added a comment.

In https://reviews.llvm.org/D27762#624265, @pcc wrote:

> You're right, sorry for the noise. But it looks like https://reviews.llvm.org/D27642 will have the same problem.

Hopefully now, as I am adding a default values for the extra parameters for DIFile creation.
But I will double check that before committing.

Thanks for pointing this out.



More information about the llvm-commits mailing list