[PATCH] D26730: AMDGPU/GlobalISel: Add support for simple shaders

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 15 13:22:37 PST 2016

arsenm added inline comments.

Comment at: lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:53
+  setAction({G_STORE, S32}, Legal);
+  setAction({G_STORE, 1, S64}, Legal);
+  setAction({G_STORE, 1, P1}, Legal);
ab wrote:
> arsenm wrote:
> > ab wrote:
> > > Huh, why are non-pointer types legal?
> > What do you mean?
> Why is it legal to have an 's64' pointer (#1) operand to G_STORE/G_LOAD/G_GEP?
Oh, I didn't realize integers and pointers were distinct here. 32-bit and 64-bit pointers should both be legal


More information about the llvm-commits mailing list