[PATCH] D27790: Pass sample pgo flags to thinlto.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 18:39:19 PST 2016


mehdi_amini added a comment.

Ouch, I see: with sample-based profiling you can't change the callgraph after the instrumentation point to have the correct information, correct? Is changing the CFG OK though? (If you have a pointer about sample-based profiling where I can find the answer to these subtle points).

Hashing the full content of the profiles would break the "fine" grain of incremental build we have now. So I'd be cautious about that, even if this is likely a marginal use-case.


https://reviews.llvm.org/D27790





More information about the llvm-commits mailing list