[PATCH] D27783: [MachineBlockPlacement] Don't make blocks "uneditable"

Kyle Butt via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 18:01:15 PST 2016

iteratee accepted this revision.
iteratee added a comment.
This revision is now accepted and ready to land.

One minor fix, but otherwise LGTM

Comment at: lib/CodeGen/MachineBlockPlacement.cpp:1680
+              !PrevBB->canFallThrough()) &&
+             "Precondition violated!");
+      Cond.clear();
Can you make the assert comment here more descriptive, something like:
"Unexpected block with un-analyzable fallthrough detected."


More information about the llvm-commits mailing list