[PATCH] D27609: Fix R_AARCH64_MOVW_UABS_G3 relocation

Yichao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 17:57:38 PST 2016

yuyichao added a comment.

> (and add the required tests please)


Comment at: test/ExecutionEngine/RuntimeDyld/AArch64/ELF_ARM64_relocations.s:9-15
+        movz    x0, #:abs_g3:f
+        movk    x0, #:abs_g2_nc:f
+        movk    x0, #:abs_g1_nc:f
+        movk    x0, #:abs_g0_nc:f
+        ret
+        .Lfunc_end0:
+        .size   g, .Lfunc_end0-g
davide wrote:
> yuyichao wrote:
> > yuyichao wrote:
> > > davide wrote:
> > > > Can you add comments pointing out the relocations emitted?
> > > Sorry, what exactly do you mean? The relocations are explicitly specified in the code (`#:abs_g3:` etc.). Do you mean to write the name like `R_AARCH64_MOVW_UABS_G3`? Or something else?
> > Or do you mean the disassemble of the relocated instructions?
> The former (spelling the as `R_AARCH64_FOO`)
OK. Will do.


More information about the llvm-commits mailing list