[PATCH] D27198: [PM] Introduce the facilities for registering cross-IR-unit dependencies that require deferred invalidation.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 17:54:40 PST 2016

chandlerc marked 2 inline comments as done.
chandlerc added inline comments.

Comment at: include/llvm/IR/PassManager.h:104
+/// ```
+///   auto PAC = PA.getChecker<MyAnalysisType>();
+///   if (PA.preserved() || PA.preservedSet<AllAnalysesOn<MyIRUnit>>() ||
silvas wrote:
> This example is a bit confusing. Where is `PAC` used?
Doh! Good catch....

Comment at: include/llvm/IR/PassManager.h:113
+/// This API directly supports the relationship between preserved sets and
+/// their being overriden by an "abandoned" name.
silvas wrote:
> What is "name"? Do you mean "analysis" or "analysis key" or something?
Yea, I have no idea. I meant what you said - "analysis".


More information about the llvm-commits mailing list