[PATCH] D27198: [PM] Introduce the facilities for registering cross-IR-unit dependencies that require deferred invalidation.

Sean Silva via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 15:44:59 PST 2016

silvas added a comment.

A couple nits. Overall, this is looking a lot better. It's awesome that you sat down with Justin to hash this out.

Comment at: include/llvm/IR/PassManager.h:104
+/// ```
+///   auto PAC = PA.getChecker<MyAnalysisType>();
+///   if (PA.preserved() || PA.preservedSet<AllAnalysesOn<MyIRUnit>>() ||
This example is a bit confusing. Where is `PAC` used?

Comment at: include/llvm/IR/PassManager.h:113
+/// This API directly supports the relationship between preserved sets and
+/// their being overriden by an "abandoned" name.
What is "name"? Do you mean "analysis" or "analysis key" or something?


More information about the llvm-commits mailing list