[PATCH] D20505: Codegen: Outline for chains of tail-duplicable blocks.

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 15:33:25 PST 2016

davidxl added inline comments.

Comment at: lib/CodeGen/MachineBlockPlacement.cpp:560
+static bool hasSameSuccessors(
+    MachineBasicBlock &BB, SmallPtrSetImpl<MachineBasicBlock *> &Successors) {
Add a documentation line to this method.

Comment at: lib/CodeGen/MachineBlockPlacement.cpp:609
+    if (!TailDup.canTailDuplicate(Succ, Pred)) {
+      if (Successors.size() > 1
+          && hasSameSuccessors(*Pred, Successors))
Add more explanation here (as comment) and possible with a simple example?


More information about the llvm-commits mailing list