[PATCH] D27636: [NVPTX] Move PropertyAnnotationNames into a cc file.

Justin Lebar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 14:40:48 PST 2016

jlebar added inline comments.

Comment at: llvm/lib/Target/NVPTX/NVPTXUtilities.cpp:270-271
   unsigned x = 0;
-  bool retval = llvm::findOneNVVMAnnotation(
-      &F, llvm::PropertyAnnotationNames[llvm::PROPERTY_ISKERNEL_FUNCTION], x);
+  bool retval = llvm::findOneNVVMAnnotation(&F, "kernel", x);
   if (!retval) {
     // There is no NVVM metadata, check the calling convention
tra wrote:
> if (findOneNVVMAnnotation()) ... ? Here and in getAlign() below?
Ugh, I accidentally merged two patches, the one moving this file into namespace llvm and the other getting rid of the constants.

I guess what's done is done.  I'll send another patch for the retval thing, though, as this is already bigger than I would like.


More information about the llvm-commits mailing list