[PATCH] D27776: LibDriver: Reject inputs that are not COFF objects or bitcode files.

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 14:28:55 PST 2016

davide added inline comments.

Comment at: llvm/lib/LibDriver/LibDriver.cpp:150-151
+        Magic != sys::fs::file_magic::bitcode) {
+      llvm::errs() << Arg->getValue() << ": not a COFF object or bitcode file\n";
+      return 1;
+    }
I wish `libDriver` had a diagnostic handler instead of accessing `llvm::errs()` directly here. Well, this seems widespread so better leave it as is.


More information about the llvm-commits mailing list