[PATCH] D27636: [NVPTX] Move PropertyAnnotationNames into a cc file.

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 13:39:48 PST 2016


tra added inline comments.


================
Comment at: llvm/lib/Target/NVPTX/MCTargetDesc/NVPTXBaseInfo.cpp:14
+namespace llvm {
+const char *PropertyAnnotationName(PropertyAnnotation A) {
+  switch (A) {
----------------
Do we really need a separate file for this? Why not just put it into NVPTXUtilities.cpp where it's used. For all practical purposes we can even make it static there as there are no other users.


https://reviews.llvm.org/D27636





More information about the llvm-commits mailing list