[PATCH] D27768: COFF: Open and map input files asynchronously on Windows.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 13:23:19 PST 2016

ruiu added a comment.

Which is actually slow, open or mmap? My wild guess is that mmap is slow. If so, can we open a file to get an error early and then mmap? It will simplify std::future<MBErrPair> to std::future<MemoryBuffer>.

Comment at: lld/COFF/Driver.cpp:794
+  run();
Is this enough to run this only once? In the above code we repeat until converge.

Comment at: lld/COFF/InputFiles.h:86
   // Returns an input file for a given symbol. A null pointer is returned if we
   // have already returned the same input file. (So that we don't instantiate
Update comment.


More information about the llvm-commits mailing list