[PATCH] D27729: [libFuzzer] Diff 20 - Update tests to use more general functions instead of posix specific.
Kostya Serebryany via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 14 13:16:11 PST 2016
kcc added inline comments.
Comment at: lib/Fuzzer/test/OutOfMemoryTest.cpp:5
// Tests OOM handling.
> mpividori wrote:
> > kcc wrote:
> > > Please don't.
> > > I want the tests to remain free of any such deps.
> > Free from dependencies from libFuzzer?? Even if this tests are linked with the LLVMFuzzer.lib library? You want me to remove the include and declare the function signature? I don't understand...
> In `CustomCrossOverTest.cpp`, `CustomMutatorTest.cpp`, and other tests, you also include:
> ` #include "FuzzerInterface.h" ` ...
I don't want these tests to depend on libFuzzer in any way.
obviously, declaring the function signature here is even worse.
These tests should be usable with other fuzzing engines.
>> CustomCrossOverTest.cpp, CustomMutatorTest.cpp,
These are the exceptions because they use cutom mutator/crossover -- something that other fuzzing engines don't support.
More information about the llvm-commits