[PATCH] D27766: [buildbot] Added CUDATestsuiteBuilder.py

Justin Lebar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 11:55:53 PST 2016

jlebar added inline comments.

Comment at: zorg/buildbot/builders/CUDATestsuiteBuilder.py:86
+                    '-DTEST_SUITE_SUBDIRS=External',
+                    ] + extra_ts_cmake_args
Nit, this would be clearer to me if it was indented like cuda_test_env above.

Comment at: zorg/buildbot/builders/CUDATestsuiteBuilder.py:135
+    # WARNING: This takes a lot of time to build.
+    if (enable_thrust_tests):
+        f.addStep(WarningCountingShellCommand(
Nit, no parens in if.


More information about the llvm-commits mailing list