[PATCH] D27679: Simplify format member detection in FormatVariadic
Zachary Turner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 14 11:23:39 PST 2016
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
I see that you added the missing format provider test. Can you also just verify by inspection that the error message is still nice when it fails? (You may have already done this, but there's no way to really write a test for it). Assuming that's fine and all the tests pass, then lgtm.
More information about the llvm-commits