[PATCH] D26367: Fix DAGCombiner match

Evgeny Stupachenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 11:21:34 PST 2016

evstupac added a comment.

> add the same snippet above to the ARM test, checking for two ldrbs and with a big FIXME saying that we need to fix PartialOffset in the DAGCombiner to make it work.

Hmm... It looks like bug report is better.

> Copy that test to the AArch64 directory, change the triple to "aarch64-linux-gnu" and change the register patterns from r[0-9] to w[0-9].

I'd leave this move for separate commit from James, you or someone else from ARM.  It should be easier for you and this move is not related to my fix.

> Change the last (added) test in AArch64 to expect ldrh and see it pass.

If you move the test before I commit the patch I'll add new check there. If after you'll need to add it.




More information about the llvm-commits mailing list