[PATCH] D27454: Extract LaneBitmask into a separate type

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 10:35:12 PST 2016

MatzeB added a comment.

In https://reviews.llvm.org/D27454#622191, @kparzysz wrote:

> TableGen includes CodeGen/MachineValueType.h.  Could we have LaneBitmask.h in CodeGen and include it here as well?

Ah I didn't notice that file before, but that looks like the "100% header only implementation" I mentioned as an alternative earlier. Maybe the idea isn't so silly and we should just do it with LaneBitmask as well, at least it is all implemented in the header at the moment anyway.



More information about the llvm-commits mailing list