[PATCH] D26283: [ELF] - Partial support of --gdb-index command line option (Part 3).

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 08:58:19 PST 2016

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

I have a few more stylistic issues, but after fixing that, feel free to commit.

Comment at: ELF/GdbIndex.cpp:157
+// slot when handling a hash collision is specified in .gdb_index section format
+// (https://sourceware.org/gdb/onlinedocs/gdb/Index-Section-Format.html)
+GdbSymbol **GdbHashTab::findSlot(uint32_t Hash, size_t Offset) {
Coding guidelines want this to be a doxygen comment on the declaration in the header. 
Is it possible to paraphrase the contents of the links in the comment? We don't usually put links into comments.

Comment at: ELF/SyntheticSections.cpp:1416
+// Iterative hash function for symbol's name is described at
+// https://sourceware.org/gdb/onlinedocs/gdb/Index-Section-Format.html
+static uint32_t hash(StringRef Str) {
same here.


More information about the llvm-commits mailing list