[PATCH] D27739: Disable libLTO tests when libLTO is not built

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 08:34:35 PST 2016


dschuff added a comment.

I realized that the gold part of this change was wrong, so I took that part out and landed just the libLTO part for now.
I also am now having second thoughts that the gold part of the change is good, because the condition for whether the gold plugin gets built is nontrivial (it's `LLVM_ENABLE_PIC` and `LLVM_BINUTILS_INCDIR` and implicitly `LLVM_TOOL_GOLD_BUILD`). So maybe just testing for the presence of the DSO is less error-prone than duplicating that logic in the lit file.


Repository:
  rL LLVM

https://reviews.llvm.org/D27739





More information about the llvm-commits mailing list