[lld] r289284 - Fix a bogus warning.

Filipe Cabecinhas via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 14 05:41:07 PST 2016


Not that it makes a big difference, but does this FileCheck option not work?
  -allow-empty                  - Allow the input file to be empty.
This is useful when making
                                  checks that some error message does
not occur, for example.

(Since you have a -fatal-warnings option on lld, that's arguably
better in this case, as it's shorter and self-explanatory enough).

Thank you,
  Filipe


On Mon, Dec 12, 2016 at 10:50 PM, Rafael Avila de Espindola via
llvm-commits <llvm-commits at lists.llvm.org> wrote:
> David Blaikie <dblaikie at gmail.com> writes:
>
>> A test that is "does not crash/error/warn" is sometimes a bit vague -
>> could/should you test that the output is as expected in this case?
>
> The expected output is empty, which FileCheck is not good at
> checking. That is why the test uses --fatal-warnings.
>
> Cheers,
> Rafael
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list