[PATCH] D27082: [LTO] Reject modules without datalayout

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 13 20:56:01 PST 2016

Sorry for the noise, I misread the code. In that case I don't think it
matters much where we return the error from.


On Dec 13, 2016 8:47 PM, "Mehdi Amini" <mehdi.amini at apple.com> wrote:

It changes the moment we emit the error (and I agree that the earlier the
better usually, even though there may be cases where you consider a module
but don’t include it in the link for instance), but I’m not sure why you
think that the current error does not easily allow to diagnose which file
has the problem, since it returns an error on the call to
`LTO.add(InputFile)` ?

On Dec 13, 2016, at 8:43 PM, Peter Collingbourne <peter at pcc.me.uk> wrote:

It could be more useful to do this in InputFile::create, that way the
client can easily diagnose which file has the problem.


On Dec 13, 2016 8:36 PM, "Mehdi AMINI via Phabricator" <
reviews at reviews.llvm.org> wrote:

mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161213/005f869f/attachment.html>

More information about the llvm-commits mailing list