[PATCH] D27676: [ELF] - Use full object name if source file name exist when reporting errors.

Sean Silva via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 13 20:51:09 PST 2016

silvas added a comment.

In https://reviews.llvm.org/D27676#621721, @ruiu wrote:

> I think my concern is that we are going to print out at most three filenames like this
>   foo.a(foo.o)(foo.c)
> and that error string format looks odd. It is indistinguishable from
>   foo.o(foo.c)
> where in this case foo.o is not an archive but an object file. I think we are using too many parentheses.

In the post-commit of r285186 I suggested using a `note:` to report the object file.

Maybe when we use a source location for the error, we can add a note something like:

  note: this definition was found in baz.a(bar.o)


More information about the llvm-commits mailing list