[PATCH] D26224: NewGVN

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added a comment.

A few more comments on the comments, otherwise, I'm fine with committing this and working on it in-tree. Thanks for your work on this!



================
Comment at: include/llvm/Transforms/Scalar/GVNExpression.h:66
+    // Compare the expression type for anything but load and store.
+    // This is needed for load coercion.
+    if (getExpressionType() != ET_Load &&
----------------
What does load coercion mean in this context? Also, for loads and stores we set the opcode to 0 and that should be noted somewhere here.


================
Comment at: lib/Transforms/Scalar/NewGVN.cpp:648
+                                                   const BasicBlock *B) {
+  // FIXME: Add bundle operators for calls.
+  CallExpression *E =
----------------
bundle operators -> operand bundles


https://reviews.llvm.org/D26224