[llvm] r289626 - Don't double-initialize cl::opt for iterating in reverse order to uncover non-determinism in codegen by default

Mehdi Amini via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 13 18:35:32 PST 2016


Author: mehdi_amini
Date: Tue Dec 13 20:35:32 2016
New Revision: 289626

URL: http://llvm.org/viewvc/llvm-project?rev=289626&view=rev
Log:
Don't double-initialize cl::opt for iterating in reverse order to uncover non-determinism in codegen by default

Bots are broken and needs to be fixed before having this on by default.
The feature was committed in r289619.

I tried to disable it in r289624 and failed because it was initialized in two places.

Modified:
    llvm/trunk/lib/Support/CommandLine.cpp

Modified: llvm/trunk/lib/Support/CommandLine.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/CommandLine.cpp?rev=289626&r1=289625&r2=289626&view=diff
==============================================================================
--- llvm/trunk/lib/Support/CommandLine.cpp (original)
+++ llvm/trunk/lib/Support/CommandLine.cpp Tue Dec 13 20:35:32 2016
@@ -52,7 +52,7 @@ namespace llvm {
 // This will help uncover differences in codegen caused due to undefined
 // iteration order.
 static cl::opt<bool, true> ReverseIteration("reverse-iterate",
-  cl::location(ReverseIterate<bool>::value), cl::init(true));
+  cl::location(ReverseIterate<bool>::value));
 }
 #endif
 




More information about the llvm-commits mailing list