[llvm] r289490 - Revert "Disable all llvm-config tests for now, will investigate later"

[Derek Schuff via llvm-commits]

Hm, sort of?
It does print the right thing for the dylib build. However when I try to
use it with a -DBUILD_SHARED_LIBS build, llvm-config throws errors:
# bin/llvm-config --libs --link-static
llvm-config: error: missing: /s/llvm-upstream/build/lib/libLLVMDemangle.a
llvm-config: error: missing: /s/llvm-upstream/build/lib/libLLVMSupport.a
... etc.

Ironically, that would probably actually make the test pass as written :/

On Tue, Dec 13, 2016 at 2:07 PM Chris Bieneman <beanz at apple.com> wrote:

> I believe the flag --link-static covers this use case.
>
> -Chris
>
> On Dec 13, 2016, at 2:02 PM, Derek Schuff <dschuff at google.com> wrote:
>
> Hi Chris,
> There does seem to be one bit of breakage hiding behind this disabled
> test; namely for the LLVM_{BUILD,LINK}_LLVM_DYLIB case, where
> `llvm-config --libs` emits '-lLLVM-4.0svn` rather than '-lLLVMCore' etc.
> tools/llvm-config/libs.test explicitly checks that LLVMCore and LLVMSupport
> are included. Any ideas about how to support both build cases?
>
> On Mon, Dec 12, 2016 at 3:25 PM Chris Bieneman via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
> Author: cbieneman
> Date: Mon Dec 12 17:14:58 2016
> New Revision: 289490
>
> URL: http://llvm.org/viewvc/llvm-project?rev=289490&view=rev
> Log:
> Revert "Disable all llvm-config tests for now, will investigate later"
>
> This reverts commit r260386.
>
> These tests all pass for me locally. I have no idea if they will pass on
> all configurations, so I'll watch the bots closely.
>
> Removed:
>     llvm/trunk/test/tools/llvm-config/lit.local.cfg
>
> Removed: llvm/trunk/test/tools/llvm-config/lit.local.cfg
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-config/lit.local.cfg?rev=289489&view=auto
>
> ==============================================================================
> --- llvm/trunk/test/tools/llvm-config/lit.local.cfg (original)
> +++ llvm/trunk/test/tools/llvm-config/lit.local.cfg (removed)
> @@ -1,2 +0,0 @@
> -# Disable all llvm-config tests for now.
> -config.unsupported = True
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161213/2869f619/attachment.html>