[PATCH] D27727: Switch DWARFDie::getAttributeValueAsString() to return an llvm::Optional<const char *>.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 13 13:26:54 PST 2016

aprantl added a comment.

I'm all for replacing the `Value getAttribute(Attr attr, Value default)` interfaces with `Optional<Value> getAttribute(Attr attr)` versions, and perhaps provide the default-value mechanism in a generic way. However, in the concrete case of a `const char *` return value I think LLVM typically returns a nullptr to signal failure.


More information about the llvm-commits mailing list