[PATCH] D27722: [GVNHoist] Move GVNHoist to function simplification part of pipeline.

Geoff Berry via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 13 11:55:03 PST 2016


gberry added a comment.

In https://reviews.llvm.org/D27722#621354, @hfinkel wrote:

> > Improvements:
>
> Nice! I'm surprised it was not there before; it is not an early-cleanup pass. Putting it right after EarlyCSE should allow it to share a MemorySSA computation with EarlyCSE (at least when we switch it over to using MSSA). LGTM.


Yeah, that (amortizing MemorySSA for EarlyCSE) was actually my main motivation for doing this.

In https://reviews.llvm.org/D27722#621354, @hfinkel wrote:

> > Improvements:
>
> Nice! I'm surprised it was not there before; it is not an early-cleanup pass. Putting it right after EarlyCSE should allow it to share a MemorySSA computation with EarlyCSE (at least when we switch it over to using MSSA). LGTM.




In https://reviews.llvm.org/D27722#621354, @hfinkel wrote:

> > Improvements:
>
> Nice! I'm surprised it was not there before; it is not an early-cleanup pass. Putting it right after EarlyCSE should allow it to share a MemorySSA computation with EarlyCSE (at least when we switch it over to using MSSA). LGTM.





https://reviews.llvm.org/D27722





More information about the llvm-commits mailing list