[PATCH] D26718: [llvm] Iterate SmallPtrSet in reverse order to uncover non-determinism in codegen

Mandeep Singh Grang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 13 11:30:43 PST 2016

mgrang added inline comments.

Comment at: unittests/ADT/CMakeLists.txt:67
+  list(APPEND ADTSources ReverseIterationTest.cpp)
mehdi_amini wrote:
> mgrang wrote:
> > Without explicitly passing LLVM_ENABLE_ABI_BREAKING_CHECKS to the compilation line of ReverseIteration.cpp, it always complains about undefined variable "ReverseIterate".
> That's not great, but I don't see a better way right now, can you at least document it in file here?
Didn't realize we needed to include llvm/Config/abi-breaking.h in the header for LLVM_ABI_BREAKING_CHECKS to be used. After including this in the header we no longer need an explicit add_definitions.


More information about the llvm-commits mailing list